Skip to content

fix(weather): reorder daily forecast columns#4118

Open
MannXo wants to merge 3 commits into
MagicMirrorOrg:developfrom
MannXo:fix/4117-weather-forecast-column-order
Open

fix(weather): reorder daily forecast columns#4118
MannXo wants to merge 3 commits into
MagicMirrorOrg:developfrom
MannXo:fix/4117-weather-forecast-column-order

Conversation

@MannXo

@MannXo MannXo commented Apr 21, 2026

Copy link
Copy Markdown

The daily forecast currently shows columns in this order: condition, max temp, min temp, precip amount, precip probability, UV Index. This is inconsistent with the order requested in the issue.

This PR reorders the daily forecast columns to: condition, min temp (low), max temp (high), UV Index, precip amount, precip probability.

Fixes #4117

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

Thanks for the PR! Can you attach a before and after screenshot?

@rejas

rejas commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

I am not sure if changing the order is a good idea. Our users are used to how this is ordered now, changing it might confuse some...

But I am willing to see the change in screenshots, before making up my mind finally...

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

@MannXo Did you noticed the request for screenshots? 🙂

@MannXo

MannXo commented May 4, 2026

Copy link
Copy Markdown
Author

@KristjanESPERANTO thank you for the reminder.
the before after screenshots are attached.
after
before

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

@MannXo Thanks for the screenshots 🙂 Please mark which is which. I think the first is the "after" one, right?

@MannXo

MannXo commented May 5, 2026

Copy link
Copy Markdown
Author

@KristjanESPERANTO indeed.
First one is the "after" and second one is "before"

@KristjanESPERANTO KristjanESPERANTO requested a review from rejas May 6, 2026 07:18
@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

@rejas What do you think?

@rejas

rejas commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Sorry for my late answer... Thanks fro your PR. I could see something like this merged, IF we could make the order configurable. So that people could arrange them to their likings. Maybe using a flex order css property would be the solution (so people could change that order via custom css)
@MannXo are you comfortable trying something like this out? Or how good are your css skills?

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

@MannXo Did you noticed the last comment? 🙂

@MannXo

MannXo commented Jun 10, 2026

Copy link
Copy Markdown
Author

@KristjanESPERANTO I feel I can do that. shall I create an issue for it first? or shall I just revert my commits on this branch and implement the flex?

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

I think it would be best to do it in this PR here. When we merge, we'll squash all the commits into one, so you don't have to worry too much about keeping the Git history clean 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants