fix(weather): reorder daily forecast columns#4118
Conversation
|
Thanks for the PR! Can you attach a before and after screenshot? |
|
I am not sure if changing the order is a good idea. Our users are used to how this is ordered now, changing it might confuse some... But I am willing to see the change in screenshots, before making up my mind finally... |
|
@MannXo Did you noticed the request for screenshots? 🙂 |
|
@KristjanESPERANTO thank you for the reminder. |
|
@MannXo Thanks for the screenshots 🙂 Please mark which is which. I think the first is the "after" one, right? |
|
@KristjanESPERANTO indeed. |
|
@rejas What do you think? |
|
Sorry for my late answer... Thanks fro your PR. I could see something like this merged, IF we could make the order configurable. So that people could arrange them to their likings. Maybe using a flex order css property would be the solution (so people could change that order via custom css) |
|
@MannXo Did you noticed the last comment? 🙂 |
|
@KristjanESPERANTO I feel I can do that. shall I create an issue for it first? or shall I just revert my commits on this branch and implement the flex? |
|
I think it would be best to do it in this PR here. When we merge, we'll squash all the commits into one, so you don't have to worry too much about keeping the Git history clean 🙂 |


The daily forecast currently shows columns in this order: condition, max temp, min temp, precip amount, precip probability, UV Index. This is inconsistent with the order requested in the issue.
This PR reorders the daily forecast columns to: condition, min temp (low), max temp (high), UV Index, precip amount, precip probability.
min-tempbeforemax-temp(low before high, per [Change Request] Weather forecast: Low before High Temperature #4116)forecast.njktouched;hourly.njkandcurrent.njkare unchangednode --run lint:prettierpassesFixes #4117